PandocMonad: allow nested data files #8822
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Data file fallbacks are now also searched in the directory that has the same name as the file minus the extension. For example, a filter with name `frob.lua` will be searched in `$DATADIR/filters/frob.lua` as well as in `$DATADIR/filters/frob/frob.lua`. This allows to place full git repositories in the data directory. Closes: jgm#6635
|
I'm on the fence about this. I see how it meets a need in the case of filters, but (a) it's slightly "magic" in the way it derives the directory name and (b) it applies to all data files, not just filters. A narrower intervention would do this just for filters. I'm just not sure what's best, hence the delay in merging this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data file fallbacks are now also searched in the directory that has the same name as the file minus the extension. For example, a filter with name
frob.luawill be searched in$DATADIR/filters/frob.luaas well as in$DATADIR/filters/frob/frob.lua.This allows to place full git repositories in the data directory.
Closes: #6635