Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload release to luarocks when a new version tag is pushed #73

Closed
wants to merge 1 commit into from

Conversation

tarleb
Copy link
Contributor

@tarleb tarleb commented Jun 22, 2024

No description provided.

@tarleb
Copy link
Contributor Author

tarleb commented Jun 22, 2024

To use this, one first needs to create a Luarocks API key here: https://luarocks.org/settings/api-keys

That key should then be added as a secret with name API_KEY here: https://github.com/jgm/lunamark/settings/secrets/actions

@tarleb
Copy link
Contributor Author

tarleb commented Jun 22, 2024

This is a bit ad-hoc and could probably be improved, but it should work.

@jgm
Copy link
Owner

jgm commented Jun 23, 2024

I want to wait a bit on this til I'm more comfortable with the release process (doing it manually).

Meanwhile, tests are messed up now (I guess because I changed the Makefile to use --local, which is needed on my system). Can you see how to fix?

@alerque
Copy link

alerque commented Jun 23, 2024

The @lunarmodules org repostiry has some reusable workflows that are a bit more robust than this for seeing when rockspecs changes, testing them against multiple versions of Lua & LuaRocks, then publishing them if everything succeeds. I've used them for several projects outside of that org namespace and they can be used as steps pretty easily anywhere. If you're interested in automatically publishing to LuaRocks I can submit a workflow that uses those tools.

@jgm
Copy link
Owner

jgm commented Jun 23, 2024

Sure, I'd be happy to consider that (of course it would depend on the details -- all things considered I like to keep things simple and avoid depending on things that might break).

@tarleb tarleb closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants