Fix incorrectly parsing links with nested []
#120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This markdown input: ```markdown [[]](https://haskell.org) [[][]](https://haskell.org) [[[][]](https://haskell.org) [[][][]](https://haskell.org) ``` In commonmark-hs, [it used to make this HTML](https://pandoc.org/try/?params=%7B%22text%22%3A%22%5B%5B%5D%5D%28https%3A%2F%2Fhaskell.org%29%5Cn%5Cn%5B%5B%5D%5B%5D%5D%28https%3A%2F%2Fhaskell.org%29%5Cn%5Cn%5B%5B%5B%5D%5B%5D%5D%28https%3A%2F%2Fhaskell.org%29%5Cn%5Cn%5B%5B%5D%5B%5D%5B%5D%5D%28https%3A%2F%2Fhaskell.org%29%22%2C%22to%22%3A%22html5%22%2C%22from%22%3A%22commonmark_x%22%2C%22standalone%22%3Afalse%2C%22embed-resources%22%3Afalse%2C%22table-of-contents%22%3Afalse%2C%22number-sections%22%3Afalse%2C%22citeproc%22%3Afalse%2C%22html-math-method%22%3A%22plain%22%2C%22wrap%22%3A%22auto%22%2C%22highlight-style%22%3Anull%2C%22files%22%3A%7B%7D%2C%22template%22%3Anull%7D): ```html <p><a href="https://haskell.org">[]</a></p> <p>[<a href="https://haskell.org">][]</a></p> <p>[[<a href="https://haskell.org">][]</a></p> <p>[[]<a href="https://haskell.org">][]</a></p> ``` In commonmark.js, [it makes this instead](https://spec.commonmark.org/dingus/?text=%5B%5B%5D%5D(https%3A%2F%2Fhaskell.org)%0A%0A%5B%5B%5D%5B%5D%5D(https%3A%2F%2Fhaskell.org)%0A%0A%5B%5B%5B%5D%5B%5D%5D(https%3A%2F%2Fhaskell.org)%0A%0A%5B%5B%5D%5B%5D%5B%5D%5D(https%3A%2F%2Fhaskell.org)): ```html <p><a href="https://haskell.org">[]</a></p> <p><a href="https://haskell.org">[][]</a></p> <p>[<a href="https://haskell.org">[][]</a></p> <p><a href="https://haskell.org">[][][]</a></p> ``` The commonmark.js output seems to be correct according to the specification: > Brackets are allowed in the [link text](https://spec.commonmark.org/0.30/#link-text) > only if (a) they are backslash-escaped or (b) they appear as a > matched pair of brackets, with an open bracket `[`, a sequence of > zero or more inlines, and a close bracket `]`.
notriddle
force-pushed
the
notriddle/balanced-links
branch
from
fe1ed0d to
87dae7b
Compare
|
beforeafter |
|
Excellent, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #119
This markdown input:
In commonmark-hs, it used to make this HTML:
In commonmark.js, it makes this instead:
The commonmark.js output seems to be correct according to the specification: