Skip to content
This repository has been archived by the owner on May 17, 2024. It is now read-only.

ISSUE-180 Updating CluserRole to include userextras/remote-client-ip #183

Merged
merged 1 commit into from
Feb 15, 2021

Conversation

justinas-b
Copy link
Contributor

Udpating ClusterRole in yaml files and in helm chart to include userextras/remote-client-ip which is required for --extra-user-header-client-ip argument
Signed-off-by: Justinas Balinskas [email protected]

@jetstack-bot jetstack-bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 23, 2020
@jetstack-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: justinas-b
To complete the pull request process, please assign joshvanl
You can assign the PR to them by writing /assign @joshvanl in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jetstack-bot
Copy link
Contributor

Hi @justinas-b. Thanks for your PR.

I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jetstack-bot jetstack-bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 23, 2020
@justinas-b
Copy link
Contributor Author

/release-note-none

@jetstack-bot jetstack-bot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Dec 23, 2020
@justinas-b
Copy link
Contributor Author

/assign @JoshVanL

@justinas-b
Copy link
Contributor Author

This PR is to address #180

@JoshVanL
Copy link
Contributor

/lgtm

@jetstack-bot jetstack-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2021
@jetstack-bot jetstack-bot merged commit 1080bc2 into jetstack:master Feb 15, 2021
@jetstack-bot jetstack-bot added this to the v0.2 milestone Feb 15, 2021
bobsongplus pushed a commit to bobsongplus/kube-oidc-proxy that referenced this pull request Jun 14, 2022
ISSUE-180 Updating CluserRole to include userextras/remote-client-ip
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants