Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled plugins to detect devbox entrypoint and alter their behavior #1830

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kadaan
Copy link
Contributor

@kadaan kadaan commented Feb 22, 2024

Summary

Extract getSubcommand from telemetry and use it to set the new DEVBOX_ENTRYPOINT environment variable in midcobra. Use the new env var in venvShellHook.sh to stop printing the banner when running via devbox run ...

Fixes: #1823

How was it tested?

Manually run a devbox with python package via both devbox shell and devbox run. When devbox shell is used, the banner is printed. When devbox run is used, the banner is not printed.

@kadaan
Copy link
Contributor Author

kadaan commented Mar 5, 2024

Another example of a command that should not print the python banner:

❯ devbox services ls
You can activate the virtual environment by running 'source $VENV_DIR/bin/activate'
No services currently running. Run `devbox services up` to start them:

@kadaan
Copy link
Contributor Author

kadaan commented Mar 5, 2024

@Lagoja @gcurtis @mikeland73 Can you offer some feedback on this? I'm game to change this if this is not how you want to approach it, but the banner messages are increasingly annoying.

…_ENTRYPOINT environment variable in midcobra. Use the new env var in venvShellHook.sh to stop printing the banner when running via devbox run ...
@kadaan
Copy link
Contributor Author

kadaan commented Apr 2, 2024

@Lagoja Any feedback?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Hide banner message from python plugin
1 participant