Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nvim-remote mode #3508

Merged
merged 1 commit into from May 19, 2024
Merged

Improve nvim-remote mode #3508

merged 1 commit into from May 19, 2024

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Apr 21, 2024 •
edited

  • If not inside a neovim session, treat as a normal nvim invocation and suspend lazygit.

  • If inside a neovim session:

    • Do not try to suspend lazygit.
    • Send q keystroke to neovim session to quit lazygit.
    • Send filename/line/etc. to neovim session.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

jesseduffield
jesseduffield requested changes Apr 25, 2024
View reviewed changes
Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just one comment

pkg/config/editor_presets.go Outdated Show resolved Hide resolved
@jesseduffield jesseduffield added the enhancement New feature or request label May 19, 2024
@jesseduffield jesseduffield changed the title improve nvim-remote mode Improve nvim-remote mode May 19, 2024
@jesseduffield
Copy link
Owner

I've taken the liberty of squashing the commits into one. Once tests pass we can merge

@jesseduffield jesseduffield mentioned this pull request May 19, 2024
Closed
@cmoog @jesseduffield
improve nvim-remote mode
615ff09 
- If _not_ inside a neovim session, treat as
  a normal nvim session and suspend lazygit.

- If inside a neovim session:
  - Do not try to suspend lazygit.
  - Send `q` keystroke to neovim session to quit lazygit.
  - Send filename/line/etc. to neovim session.
@jesseduffield jesseduffield merged commit 269d012 into jesseduffield:master May 19, 2024
14 checks passed
@jesseduffield jesseduffield mentioned this pull request May 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesseduffield jesseduffield Awaiting requested review from jesseduffield

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cmoog @jesseduffield