Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase Jenkins version to 2.440.3 #108

Merged
merged 7 commits into from
Oct 2, 2024

Conversation

mPokornyETM
Copy link
Contributor

Increase Jenkins version 2.440.1 to allow next feature development

Testing done

Submitter checklist

@mPokornyETM mPokornyETM added dependencies megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours labels Apr 5, 2024
@MarkEWaite
Copy link
Contributor

I was a little surprised by the choice of 2.440.1 as the baseline. The recommendation from the documentation is currently either 2.414.3 or 2.426.3

I'm fine with this change but was surprised. Was there a specific reason you chose this version as the base?

@mPokornyETM
Copy link
Contributor Author

mPokornyETM commented Apr 10, 2024

I was a little surprised by the choice of 2.440.1 as the baseline. The recommendation from the documentation is currently either 2.414.3 or 2.426.3

I'm fine with this change but was surprised. Was there a specific reason you chose this version as the base?

There is no specific reason. The same docu https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/#currently-recommended-versions says, that it might ber used. And we have currently the same version on our productive system. And I dont want to change the version in plugin so rapidly. Therefore the highest as possible.

gounthar and others added 3 commits July 2, 2024 10:07
Use the same pattern as is now used in the Jenkins archetype so that
the Jenkins plugin BOM version uses the same version as the Jenkins
minimum version.

Use Jenkins 2.440.3 because it is now one of the recommended versions
https://www.jenkins.io/doc/developer/plugin-development/choosing-jenkins-baseline/
@MarkEWaite MarkEWaite changed the title Increase Jenkins version to 2.440.1 Increase Jenkins version to 2.440.3 Aug 1, 2024
@MarkEWaite
Copy link
Contributor

@mPokornyETM I've incremented the minimum Jenkins version to 2.440.3 and switched the pom file to use the jenkins.baseline technique that is now used in the Jenkins plugin archetype. That aligns the plugin BOM version number with the minimum Jenkins version.

@MarkEWaite MarkEWaite added chore Reduces future maintenance and removed dependencies labels Aug 1, 2024
@mPokornyETM
Copy link
Contributor Author

Jenkins plugin archetype

Migh you passte here some link with the example please?. Thx

@MarkEWaite
Copy link
Contributor

Might you paste here some link with the example please?. Thx

The Jenkins plugin archetype has been updated to include a baseline version string (jenkins.baseline) that is used to provide both the Jenkins minimum version (jenkins.version) and the artifactId of the plugin BOM. Refer to the pull request:

A request has also been made that recommends an OpenRewrite recipe be created to perform the transformation so that it can be done more easily. That request is:

This pull request is manually performing the transformation that eventually it is hoped will be done with an OpenRewrite recipe. There are already many useful OpenRewrite recipes for Jenkins in addition to the more general OpenRewrite recipes for Java development that can be used for Jenkins plugins.

@mPokornyETM mPokornyETM merged commit b46376a into jenkinsci:master Oct 2, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Reduces future maintenance megre in 24 hours without review When nobody request a change or leave comment here I will merge it in 24 hours
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants