Issue #232 CreateInstances for new StackSets and UpdateInstances per parameters #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tylersouthwick
requested changes
Nov 12, 2020
| @@ -42,6 +42,7 @@ | |||
| import javax.annotation.Nonnull; | |||
| import java.io.IOException; | |||
| import java.util.Collection; | |||
| import java.util.Objects; | |||
There was a problem hiding this comment.
please remove this unused import
There was a problem hiding this comment.
Thank you for your review and inputs. I have tried to incorporate them. Kindly review and advise
|
@tylersouthwick is this still relevant? Would merge it and release a new version soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To provide support for CreateInstances and UpdateInstances along the lines of Issue #232
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
This is a feature enhancement. It allows for Stackset creation and updates by accounts/regions rather than for all accounts/regions in the Stackset. It basically is a fork of the existing function cfnUpdateStackSet with all the same features with the additional option of specifying accounts/regions
What is the current behavior? (You can also link to an open issue here)
Current function cfnUpdateStackSet does not provide for a way to specify accounts/regions. Issue [Feature] CreateStackInstances and UpdateStackInstances #232
What is the new behavior (if this is a feature change)?
A new function cfnUpdateStackSetForAccounts is built to specify accounts and regions in StackSet updates in the lines of Issue [Feature] CreateStackInstances and UpdateStackInstances #232
Does this PR introduce a breaking change? (What changes might users need to make in their setup due to this PR?)
This is a non-breaking change. A function cfnUpdateStackSetForAccounts has been introduced that has the same features as cfnUpdateStackSet but with the option to supply accounts and regions
Other information:
Example function calls:
cfnUpdateStackSetForAccounts(stackSet:'myStackSetForAccounts', file:'myStackSetForAccounts.yml', pollInterval:1000, accounts:["012345678901"], regions:["us-east-1","us-east-2"])
Changes:
Added CFNUpdateStackSetForAccountsStep.java
Added CFNUpdateStackSetForAccountsStepTest.java