Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-66079] Allow setting hookUrl from the global configuration page #376

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[JENKINS-66079] Allow setting hookUrl from the global configuration page #376

wants to merge 2 commits into from

Conversation

franknarf8
Copy link

@franknarf8 franknarf8 commented Apr 5, 2024 •
edited

This PR fixes JENKINS-66079.

It is actually not possible to set hookUrl from the global config page since 2019. The hookUrl setter is not recognized by the bindJSON code since the input parameter type change from URL to String.

The following test crashes with the code prior to my changes :

@Test
public void hookUrlShouldHaveAWriteMethod() throws Throwable {
    PropertyDescriptor hookUrlWrite = PropertyUtils.getPropertyDescriptor(
            new GitHubPluginConfig(new ArrayList<>()), "hookUrl"
    );
    assertNotNull("hookUrl write method should exits", hookUrlWrite.getWriteMethod());
}

Testing done

Re-enabled and modernized the test suite regarding global configs.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Frank Genois added 2 commits April 5, 2024 16:21
Re-enabled disabled global config tests + updated to more recent boil…
4abefb8 
…erplate
JENKINS-66079 Set hookUrl properly from global configurations page
ca3a27d 
- Broken since 2019 : 4be509e
- The hookUrl setter is not recognized by the bindJSON code since the input
  parameter type change from URL to String

The following test crashes with the previous code :
```
@test
public void hookUrlShouldHaveAWriteMethod() throws Throwable {
    PropertyDescriptor hookUrlWrite = PropertyUtils.getPropertyDescriptor(
            new GitHubPluginConfig(new ArrayList<>()), "hookUrl"
    );
    assertNotNull("hookUrl write method should exits", hookUrlWrite.getWriteMethod());
}
```
@franknarf8 franknarf8 changed the title JENKINS-66079 Allow setting hookUrl from the global configuration page [JENKINS-66079] Allow setting hookUrl from the global configuration page Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@franknarf8