WIP Deprecate magic method. #149
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
admin:repo_hook mention in help
handle exceptions of extensions
will be useful in repository name
caused by self-test validation for custom hook url
fix "Unknown content type null" in logs and since for 1.12.0 api
See JENKINS-29794 for details.
[JENKINS-29787] Fix NPE for race condition(?).
instead of own plain token usage
- with credentials usage - with migrator from old gh-push-trigger descriptor config options to new gh-plugin - with bean class to store deprecated creds (used only for migration)
+ reformat some code + add getters for fields
cleanup all gh-push-trigger descriptor related lines
- for migration process - for changes in hooks - for configuration logic
- change dontManageHooks=false to manageHooks=true
…nced also fix some phrases in javadocs and help
also don't bother signature validation if no header from github with signature
[JENKINS-33974] Payload verification using shared secrets
[JENKINS-37481] Ignore sign header if sign not defined in Jenkins
Allow for commit status backref configuration
* [FIXED JENKINS-38347] Use Initializer levels. - migrator: Don't throw NPE because Descriptor wasn't ready. - aliases: user annotation initializer. * Ensure execution order. Signed-off-by: Kanstantsin Shautsou <[email protected]> * Move to javadoc
Signed-off-by: Kanstantsin Shautsou <[email protected]>
lanwen
reviewed
Nov 14, 2016
| @@ -90,8 +90,15 @@ public void setConfigs(List<GitHubServerConfig> configs) { | |||
| return configs; | |||
| } | |||
|
|
|||
| /** | |||
| * @deprecated get GitHubServerConfig matching to exact remote GH server, filter and only then check allowToManage | |||
There was a problem hiding this comment.
this method exists only to check - can we ever manage hooks somewhere
There was a problem hiding this comment.
nope, we can skip some actions if no any server is allowed to manage hooks (such as cleanup)
|
should be notice, not deprecation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relying on this manageHooks may end to situation that it will try register hook for GH server that has disabled hooks.
PS One line fluent is hardly readable for eyes.
This change is