Handle NOT_BUILT results more clearly #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justusbunsi
reviewed
Mar 8, 2023
| @@ -106,6 +106,9 @@ private static void sendNotifications(Run<?, ?> build, TaskListener listener) | |||
| } else if (Result.FAILURE.equals(result)) { | |||
| status.setDescription("There was a failure building this commit"); | |||
| status.setState(GiteaCommitState.FAILURE); | |||
| } else if (Result.NOT_BUILT.equals(result)) { | |||
| status.setDescription("This commit was not built"); | |||
| status.setState(GiteaCommitState.UNKOWN); | |||
There was a problem hiding this comment.
There is a typo in the unknown.
How will Gitea handle this status? From the docs it says It can be "pending", "success", "error", "failure", and "warning".
There was a problem hiding this comment.
Ok, missed that it was a requirement from gitea. Updated the commit and the state to warning. It is not as clear but hopefully less confusing.
There was a problem hiding this comment.
Warning is better than the current "fatal error". 👍
I think such unknown state would be a good addition on Gitea side. But that requires a change in Gitea repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jenkins job that have Result NOT_BUILT are reported as errors which confuses developers.
Added new commit state UNKNOWN and handle NOT_BUILT Result with description "This commit was not built".