This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
Build feature branches in Maven-based draft packs #84
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a request for feedback on how the Jenkinsfile has been restructured for Maven-based draft packs. I recognize that there is a desire to move to prow commands, and that there are a lot of opinions on how to structure a build pipeline, and so this PR may not go anywhere.
The previous pipeline flow used stages to control conditional execution of steps. For example, a build stage existed for PR branches, and another build stage existed for master. Here is an example (note that an Acceptance Tests stage was added when I was experimenting with it):
Feature branches were not being built using the Jenkinsfile, which was fixed; in addition to building all branches, the file was re-worked so that each stage feeds into the next stage like a pipeline, where all branches go through a pre-build stage, then a build stage, etc. The conditional execution is controlled within the stage.