Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Build feature branches in Maven-based draft packs #84

Open
wants to merge 2 commits into
base: 2.1
Choose a base branch
from

Conversation

benvandenberg
Copy link

This pull request is a request for feedback on how the Jenkinsfile has been restructured for Maven-based draft packs. I recognize that there is a desire to move to prow commands, and that there are a lot of opinions on how to structure a build pipeline, and so this PR may not go anywhere.

The previous pipeline flow used stages to control conditional execution of steps. For example, a build stage existed for PR branches, and another build stage existed for master. Here is an example (note that an Acceptance Tests stage was added when I was experimenting with it):

image

Feature branches were not being built using the Jenkinsfile, which was fixed; in addition to building all branches, the file was re-worked so that each stage feeds into the next stage like a pipeline, where all branches go through a pre-build stage, then a build stage, etc. The conditional execution is controlled within the stage.

image

@michaelneale
Copy link

I like this - I don't know the ins and outs of the intention of maven with Jenkins X - but knowing a tiny bit about pipeline, this does seem fairly idiomatic. I imagine there are advantages to buildign feature branches - but wont this create more builds before a PR is actually opened? is this a problem?

cc @rawlingsj @jstrachan does this look ok to you?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants