This repository has been archived by the owner on Nov 27, 2018. It is now read-only.
JVM memory settings from the memory limit of docker container #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jstrachan @rawlingsj I think this change would help especially new users overcome an unnecessary hurdle. A couple of more references regarding this feature: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are intended to remove the risk for experiencing out of memory kill on containers due to the jvm calculating higher memory limits that what are set on the container (via values.yaml).
For background and details see https://blogs.oracle.com/java-platform-group/java-se-support-for-docker-cpu-and-memory-limits
In java 10 this will be the default behaviour