Skip to content
This repository has been archived by the owner on Nov 27, 2018. It is now read-only.

Issues with Go Draft Pack in 2.1 Branch #55

Open
allen-servedio opened this issue Jul 19, 2018 · 1 comment
Open

Issues with Go Draft Pack in 2.1 Branch #55

allen-servedio opened this issue Jul 19, 2018 · 1 comment

Comments

@allen-servedio
Copy link
Contributor

I ran into the following two issues with the Go Draft pack in the 2.1 branch:

  • This fix has not been applied to the branch: 7d06a59
  • When using the quick start for go (jx create quickstart -l go), it does not use the Git Hub org you select for your repo when generating the JenkinsFile (it uses your default org). So REPLACE_ME_ORG in https://github.com/jenkins-x/draft-packs/blob/2.1/packs/go/Jenkinsfile is not being replaced with the github org my application is created it.
rawlingsj added a commit that referenced this issue Jul 19, 2018
@allen-servedio
Copy link
Contributor Author

#56 fixed the first point in this ticket.

However, the second point (not using the org that the user selects when setting the org for the Jenkinsfile) is still not correct. Perhaps this can be fixed when #57 is worked on...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant