Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add lint step and fix linting issues #233

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

refactor: add lint step and fix linting issues #233

wants to merge 1 commit into from

Conversation

ankitm123
Copy link
Contributor

Signed-off-by: ankitm123 [email protected]

@jenkins-x-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rawlingsj
You can assign the PR to them by writing /assign @rawlingsj in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ankitm123
Copy link
Contributor Author

/cc @rawlingsj

@ankitm123
Copy link
Contributor Author

/hold
go-plugin-multiarch does not have make-lint step.

@ankitm123
Copy link
Contributor Author

/test pr

@ankitm123
Copy link
Contributor Author

/hold cancel

@ankitm123 ankitm123 force-pushed the lint-repo branch 8 times, most recently from 546853e to 316ce20 Compare November 6, 2021 18:46
@sonarcloud
Copy link

sonarcloud bot commented Nov 28, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ankitm123
ankitm123 commented Nov 28, 2021
View reviewed changes
OWNERS
@@ -2,7 +2,9 @@ approvers:
- rawlingsj
- jstrachan
- rajdavies
- ankitm123
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can help with reviewing/approving PRs ...

@ankitm123
Copy link
Contributor Author

sonarcloud checks can be ignored, as they are unrelated to my changes ....

@ankitm123
Copy link
Contributor Author

/test all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rawlingsj rawlingsj Awaiting requested review from rawlingsj

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ankitm123 @jenkins-x-bot