Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement/rabbitmq channel #1204

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

LarryMatrix
Copy link

Implementation of rabbitmq enabling openhim to publish message in rabbitmq and returning response to the source in less response time.

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #1204 (c22ed11) into master (4ab86ea) will decrease coverage by 0.28%.
The diff coverage is 9.52%.

❗ Current head c22ed11 differs from pull request most recent head 8934fa3. Consider uploading reports for the commit 8934fa3 to get more accurate results

@@            Coverage Diff             @@
##           master    #1204      +/-   ##
==========================================
- Coverage   86.81%   86.53%   -0.28%     
==========================================
  Files          87       87              
  Lines        5906     5926      +20     
==========================================
+ Hits         5127     5128       +1     
- Misses        779      798      +19     
Files Changed Coverage Δ
src/model/channels.js 100.00% <ø> (ø)
src/middleware/router.js 86.76% <9.52%> (-5.12%) ⬇️

@rcrichton
Copy link
Member

Thanks for the contribution! To merge this we would need some tests to be added and some instruction on how to test this. Is there also a PR for the openhim-console to add this functionality to the UI?

Comment on lines +521 to +525
route.type === 'kafka'
? sendKafkaRequest
: route.type === 'rabbitmq'
? sendRabbitMQRequest
: sendHttpRequest
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This chained logic is a bit confusing, perhaps rather split this out to a switch statement or something rather than chaining ternaries.

@rcrichton
Copy link
Member

Do you also have a particular use case where you are using RabbitMQ with OpenHIM. I'd love to hear about it.

@LarryMatrix
Copy link
Author

LarryMatrix commented Sep 14, 2023 via email

@LarryMatrix
Copy link
Author

LarryMatrix commented Sep 14, 2023 via email

@LarryMatrix
Copy link
Author

LarryMatrix commented Sep 14, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants