Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove outdated meta element for EOL IE #74

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Rotzbua
Copy link
Contributor

@Rotzbua Rotzbua commented Jan 14, 2022

Copy link
Owner

@jeffreytse jeffreytse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you explain further why this meta node is being removed?

@jeffreytse jeffreytse self-assigned this Jan 18, 2022
@Rotzbua
Copy link
Contributor Author

Rotzbua commented Jan 22, 2022

As mentioned in the linked source the meta is only used by ancient IE versions (6 years EOL!).
On the "current" IE11 the meta has no effect, so it is not useful.

@jeffreytse
Copy link
Owner

@Rotzbua But there are still some people are using IE8 or IE9, right? Should we ignore them nowadays? Thanks and Regards

@Rotzbua
Copy link
Contributor Author

Rotzbua commented Feb 2, 2022

@Rotzbua But there are still some people are using IE8 or IE9, right? Should we ignore them nowadays? Thanks and Regards

There are always "some" people using ancient software. The current statistics from browserslist claims for IE 5.5-9 about 0.14% globally. Most modern web frameworks kicked the support for lower than IE 11.

From a dev perspective I think it is hard to keep IE 8/9 support because you need a test setup 😄

@Rotzbua Rotzbua changed the title fix: remove not needed meta element fix: remove outdated meta element for EOL IE Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants