Skip to content
This repository has been archived by the owner on Apr 25, 2024. It is now read-only.

Fixed undesired line breaks and Markdown syntax for Links. #84

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

a-inacio
Copy link

Hello!

I fixed some minor bugs that were preventing me to be able to use geeknote properly, hope you find then useful as well.

Cheers

More information here (from the commit message):

The mentioned line breaks where corrupting URLs, after some default line length, so text was being split into lines automatically (and therefore corrupting URLs).
Links of type http://someurl.com can be expressed as http://someurl.com, so we have to tell the markdown processor to handle it like such.

The mentioned line breaks where corrupting URLs, after some default line length, so text was being split into lines automatically (and therefore corrupting URLs).
Links of type [http://someurl.com](http://someurl.com) can be expressed as <http://someurl.com>, so we have to tell the markdown processor to handle it like such.
@jeffkowalski
Copy link
Owner

@AntonioInacio, thanks for the fixes. You'll see that the tests are now failing, though. Would you correct the errors, and also maybe insert a new test that exercises your changes?

@a-inacio
Copy link
Author

Upps sorry about that!
Will look into it and give you feedback.

Cheers

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants