Develop/issue 863 #864
Open
Develop/issue 863 #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e changes - this one doesn't need to be part of Cecil as the APIs are now there to support it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a change towards addressing the platform dependent behaviour of the Cecil binaries when resolving system assemblies.
This change extracts the net core and framework system assembly search strategies into
protectedmethods that will be available in all builds -- avoiding the need to reimplement both in a platform neutral subclass; and provides a hook for examining the result before or after any resolution handler invocation, and making any other adjustments before an exception is thrown.Additionally, in order to allow a custom resolver to instantiate per-assembly in the manner of
DefaultAssemblyResolverwhen instantiated as a fallback, a layer ofIAssemblyResolverProvidertypes and properties has been added.There are no changes to the existing platform dependent behaviour at this point -- the NET_CORE build doesn't look in the GAC, and the !NET_CORE one doesn't look in the dotnet shared locations, for example. Nor are any new resolver types or resolver provider types involved in the process without a caller opting in.