Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduced amount of checkout, simplifying things a bit. #14

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Reduced amount of checkout, simplifying things a bit. #14

wants to merge 2 commits into from

Conversation

jarl-dk
Copy link

@jarl-dk jarl-dk commented Oct 11, 2012

This is also to unify that revision is in context of the repository (not the local working repository)

@jarl-dk
Copy link
Author

jarl-dk commented Oct 11, 2012

You should also be aware of seattlerb/rake-remote_task#19

@ktheory
Copy link
Collaborator

ktheory commented Oct 11, 2012

What's the motivation here?

I'm not sure that shallow clones are faster for most use cases. Some example here show shallow clones are ~89% the size of a full clone.

This patch would do the shallow clone every deploy; whereas fast checkout only downloads the changes since the last commit.

@jarl-dk
Copy link
Author

jarl-dk commented Oct 11, 2012

I don't mind skipping the --depth= argument completely for stability/clarity reasons... It will also eliminate any concerns regarding is_commit_id?(revision) My personal experience though is that the size is ~50% size, only really large projects (linux kernel) goes down to ~15%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants