Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When identifying a macOS or Windows platform, do not include the version #187

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ataylor32
Copy link
Contributor

Addresses #160

@WhyNotHugo
Copy link
Member

Why do we want to drop this? Some browsers might still send the information, I see no reason to discard it when available.

@ataylor32
Copy link
Contributor Author

ataylor32 commented Jun 13, 2024

This comment goes into detail, but, in short, specific versions can't be trusted anymore. As an example, Chrome on macOS will report itself as running on macOS 10.15.7 even if the user is on a much newer version of macOS. So if you see that a user is using macOS 10.15.7, you don't know if it's the real macOS 10.15.7 or if it's actually a newer version. At this point, macOS 10.15.7 is old enough that if you see it, it's probably not true, but you have no way of knowing which version they're actually using.

@WhyNotHugo
Copy link
Member

Do Windows XP, 7 and 8 also spoof the OS version in user agents?

@mbeijen
Copy link
Contributor

mbeijen commented Jun 13, 2024

It is not the OSes that provide the useragent, it is the browser. So if you would run a recent chrome on Win8 etc, you will also not see Win8 but this static version of Windows 10.

The reason why I think we should no longer display the version of the OS is because of this: if you are logged and check your open sessions and you see Windows 10 but you do not have a Windows 10 device but only a Windows 11 device or Win8 or what you can get concerned for no reason. If we can’t know the version of the os (and with 99% of traffic this is the case) we should not show data that is mostly wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants