-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
It's no longer possible to properly detect the platform version, so we shouldn't try to #160
Comments
Sounds like excluding versions would be best here. Are other browsers following suit here? Or should be do this only for Chrome/Chromium? |
its still possible to detect the correct OS (depening on the clients browser), https://www.whatismybrowser.com/ will tell you that you are using windows 11. they also write how it is detected (is called "client hints"). however i dont know how much coverage there is from browser developers. Works with Chrome. (Does not work with Firefox). i think the most consistent solution is to cut-off the version from the users display. |
Yeah, indeed it would be best to exclude the version and just show "Windows" or "macOS" or "Linux" or... instead. All major browsers have implemented these anti-fingerprinting measures (Chrome, Firefox, Edge, Safari) |
Since about a year, all major browsers no longer properly show the platform they're running on to combat fingerprinting and to improve privacy.
See https://developer.chrome.com/articles/user-agent-client-hints/ and https://www.chromium.org/updates/ua-reduction/
As a result, a Windows 11 device will always show up as Windows 10 according to the user agent parsing in this module (and a Windows 10 device will also show up as Windows 10) and Mac devices will show up as running on 'macOS Catalina' while they might be running Monterey or Ventura.
Expected Behavior
If you want to manage your sessions, it can be confusing or even alarming to show sessions from 'windows 10' while you know for sure you only have devices running Windows 11. I would expect to see proper identifyable information
Current Behavior
On the latest releases of macOS or Windows, django-user-sessions shows incorrect information
For instance, on my recent Mac my user-agent is:
where
sw_vers
does not show 10.15 but rather 12.6 (Ventura)Possible Solution
We should limit the device information to show just 'macOS', or 'Windows', so there is no incorrect information displayed in the sessions overview
Steps to Reproduce (for bugs)
/account/sessions
or check the 'device' column in the sessions tableThe text was updated successfully, but these errors were encountered: