Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improvement: Github Action to Markdown link checke #1167

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

olivierodo
Copy link

Types of Changes

What types of changes does your PR introduce? Put an x in all boxes that apply

  • New addition to list
  • Fixing bug in existing item in list
  • Removing item from list
  • Changing structure (organization) of list

Proposed Changes

Hello @jaywcjlove,
I came across your AMAZING repo and after clicking in a few links I came through a few invalid links...
Then allow me to propose a Github action that would be able to detect the if a link is dead or not 😅.

The Github action used is https://github.com/marketplace/actions/404-links

Let me know if you have any question.

PR Checklist

Put an x in the boxes once you've completed each step. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING guide
  • I have explained why this PR is important
  • I have added necessary documentation (if appropriate)

Further Comments

While running the Link checker on my fork, here is the result:

image

Result available here : https://github.com/olivierodo/awesome-mac/actions/runs/4002014491

@olivierodo olivierodo marked this pull request as draft January 25, 2023 02:53
@olivierodo
Copy link
Author

Converting this PR as draft since it's required more work on the following:

  • Delete dead link
  • Remove or ignore link with ssl issues
  • Manage the rate limit of the app store (64 links impacted)
    • Option 1: use the delay option to fit in the rate limit but the action will take longer time to run
    • Option 2: Add app store / itunes into the whitelist.

Let me know you are interested then i'll continue. 😁

@jaywcjlove jaywcjlove closed this Jun 8, 2023
@jaywcjlove jaywcjlove reopened this Jun 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants