-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
out of need #30
Open
robertleeplummerjr
wants to merge
31
commits into
jawj:master
Choose a base branch
from
robertleeplummerjr:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
out of need #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the method 'setZIndexOffset'
fix keepSpiderfied add central point based off last location expose events
…/properties/methods
I went ahead and created a full fledged control that should make reuse pretty easy and simplified some of the terminology. You can now do this with this branch: L.spiderfy({
map: map,
markers: markers,
click: function(marker) {
popup.setContent(marker.desc);
popup.setLatLng(marker.getLatLng());
map.openPopup(popup);
},
activate: function(markers) {
markers.forEach(function(marker) {
marker.setIcon(new LightIcon());
});
map.closePopup();
},
deactivate: function(markers) {
markers.forEach(function(marker) {
marker.setIcon(new DarkIcon());
});
}
}); |
expose methods on L.Spiderfy found on the Spiderfy class fix bug when not active or disabled, letting the original event fire bump version number
…thrown away by leaflet
remove confusing extend
I don't trust it. |
What? |
expose global spiderExample, to play around with, if you are a developer
…visibleMarkers rather than all markers
…pider legs staying in map when under large load
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this fine library. I did some cleanup and modernization to it in hopes that it would help me and thought I'd offer it if needed.
Thanks again.