Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bugfix] mobile printing #194

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

evanb2
Copy link

@evanb2 evanb2 commented Dec 18, 2019

Implements fixes suggested in these issues:

#193
#152

Let me know if you want these split into individual PRs.

Relying on timeouts doesn't work on mobile.

Implements fix suggested here:
jasonday#193 (comment)
@jasonday
Copy link
Owner

Looks good. Do you mind separating out?
I'm iffy on approving the hack only approach fully, but would like the PR for people to use.

My plan is to look at other methods over the holiday break.

@oculus42
Copy link
Collaborator

This fix appears to have Chrome on iOS printing the entire page rather than just the requested area.

I put together two test pages in Codepen:

base test
PR 194 test

I've tested with Safari, Chrome, and Opera on an iPhone.
Will test on an iPad later today and provide a matrix of results.

@evanb2
Copy link
Author

evanb2 commented Dec 19, 2019

@oculus42 Yeah I noticed that as well but wasn't sure if it was a bug in the library or my application code/css.

@evanb2
Copy link
Author

evanb2 commented Jan 22, 2020

@guptanisha The only issue this solves on iPad (or iPhone) + Chrome is that is successfully opens the Print dialog. There is still another bug in that is does not correctly select the iFrame content for printing. Instead you just get the entire content of the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants