Add pending downloads prompt #435
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is ready. Make sure you see the it depends on #432! |
|
I would've preferred it would open the downloads settings specifically but I don't really know how to do that :( Feel free to edit this PR if you know how, or contact me on Discord if you want to help :) |
Natanel-Shitrit
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #420
Depends on #432: without this, downloads will not start when changing preferences.
Currently it's not a-lot, just added a check in the download pending callback to open a prompt if a preference is enabled (by default)
Can be disabled in the downloads settings
Prompt has 2 buttons:
I'm not adding the option to change preference from the prompt because it's unknown if it's because of the mobile data or roaming (or any other reason that may be introduced in the future)
Join Discord group to help :)