Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setAlphaSliderVisible() bug fixed #88

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mianaliasjad
Copy link

@mianaliasjad mianaliasjad commented May 2, 2020

I have fixed issue with a scenario:

in XML make app:cpv_alphaChannelVisible="false" and in code on button click colorPickerView.setAlphaSliderVisible(true); it was not showing alpha slider becasue onSizeChanged(int w, int h, int oldw, int oldh) was not gettlng called after requestLayout();

so i have moved code from onSizeChanged(int w, int h, int oldw, int oldh) to onLayout(boolean changed, int left, int top, int right, int bottom).
Also created a simple getter method to check if Alpha slider is visible or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant