Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

fix: enforce defaults in OCP form view #154

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented Nov 23, 2023

Description of the change

OCP Console is acting strangely when we want to default to [], it assumes it's null and pulls data from the schema. This PR should ensure the schema is always consistent with default values in the chart, including values for subcharts.

Existing or Associated Issue(s)

Fixes: #151

Additional Information

Kapture.2023-11-23.at.15.25.42.mp4

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The pre-commit utility can be used to generate the necessary content. Use pre-commit run -a to apply changes.
  • JSON Schema template updated and re-generated the raw schema via pre-commit hook.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

@tumido tumido requested a review from a team November 23, 2023 14:28
@tumido
Copy link
Member Author

tumido commented Nov 23, 2023

cc @kadel

@tumido
Copy link
Member Author

tumido commented Nov 24, 2023

CI failing due to janus-idp/backstage-showcase#813 please retrigger once new build for next finishes.

@kadel kadel merged commit addbde9 into janus-idp:main Nov 24, 2023
2 of 3 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to upgrade configuration when deployed from OpenShift web console
2 participants