Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: major: add account detail and card history page #1

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

linyahu
Copy link
Contributor

@linyahu linyahu commented Mar 22, 2024

Pull Request Case Study

Background Context
You currently run a small engineering team building a full stack application for Apex Financial Group, a fintech start up that offers low-interest credit cards. AFG needs a tool to manage their cardholders and check on a regular basis which cardholders have fallen behind on their monthly payments. This tool is currently being developed, and currently has a very basic search page that allows a user to enter in search parameters to get a list of cardholder accounts that match.

Alice, a junior engineer on your team, has been tasked with adding to that feature. Her project includes:

  • Creating an account details page that displays information about the cardholder:
  • Creating a history table that shows when the cardholder has made payments on their card
  • Adding some new columns to the initial search page to show a card's overdue balance (if any) as well as a column for how many days this card balance is overdue
  • Creating the necessary backend methods and API calls that support this new feature

She's been struggling with completing this task, and has been more than a week delayed in finishing up this project. She has also not proactively raised issues or blockers with her tasks.

Requirements

  • Review Alice's PR thoroughly with suggestions of improvement. Comment live with your interviewer or use your GitHub account to prep a "pending review".
  • Discuss with your interviewer how you would approach Alice in a 1-1 review of her work. This should include more high level feedback about Alice's performance and identify areas for improvement.

@linyahu linyahu force-pushed the alice-feature branch 3 times, most recently from 0349a3c to 2023900 Compare March 22, 2024 22:18
@linyahu linyahu closed this Dec 16, 2024
@linyahu linyahu reopened this Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants