Rename signals_linux.go to signals_posix.go #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 00adde7 added signals support and used the go:build directive to handle different GOOS. However, since the signals_linux.go files uses one of Golang's magic file name OS endings (_linux.go), it is ignored when GOOS=darwin. To remedy this, I simply renamed the file to signals_posix.go since it includes POSIX signals such as SIGHUP and SIGTERM.
"/gonb" is the artifact from "go build" and should be excluded from accidental commits.
|
Thanks Evan @neomantra ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 00adde7 added signals support and used the go:build directive
to handle different GOOS. However, since the signals_linux.go files uses
one of Golang's magic file name OS endings (_linux.go), it is ignored when
GOOS=darwin.
To remedy this, I simply renamed the file to signals_posix.go since it includes
POSIX signals such as SIGHUP and SIGTERM.