Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump httpx dependency to 1.0 #88

Merged
merged 1 commit into from
Oct 4, 2023
Merged

Conversation

HoneyryderChuck
Copy link
Contributor

httpx 1.0.0 has been released today.

lib/down/httpx.rb Outdated Show resolved Hide resolved
@janko
Copy link
Owner

janko commented Oct 4, 2023

Looks good, thanks!

@janko janko merged commit e90927d into janko:master Oct 4, 2023
5 of 9 checks passed
@HoneyryderChuck HoneyryderChuck deleted the httpx-v1 branch October 4, 2023 10:19
@ollym
Copy link
Contributor

ollym commented Apr 19, 2024

@janko please can you cut a new gem with this in it?

@janko
Copy link
Owner

janko commented Apr 19, 2024

Sure thing, just released 5.4.2 with these changes 📦

@janko
Copy link
Owner

janko commented May 12, 2024

@HoneyryderChuck This version specifier was still selecting the 0.x version, I just updated it to 1.x on master, and tests are failing. Would you mind helping me out with those?

@HoneyryderChuck
Copy link
Contributor Author

hey @janko thx for the heads-up. There was a regression in the stream plugin which affected this integration. I'm working on it, will let u know when done.

@janko
Copy link
Owner

janko commented May 14, 2024

Appreciate it, thanks 🙂

@HoneyryderChuck
Copy link
Contributor Author

just released 1.2.5.

@ollym
Copy link
Contributor

ollym commented May 14, 2024

🙏 deploying now to production and will let you know if Down.backend :httpx has any further issues

@janko
Copy link
Owner

janko commented May 14, 2024

Great, all of the HTTPX backend tests now pass 👌🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants