Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use-trace-processor-shell flag to automate large trace processing #248

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Add use-trace-processor-shell flag to automate large trace processing #248

wants to merge 7 commits into from

Commits on Jul 18, 2022

  1. mega traces: some early work 

    Signed-off-by: Abena Laast <[email protected]>
    @salaast
    salaast committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    86aebc1 View commit details
    Browse the repository at this point in the history

  2. Add trace_processor_exe and open_url flags to run_command in trace.ml… 

    … to allow large trace processing and url opening automation

Signed-off-by: Abena Laast <[email protected]>
    @salaast
    salaast committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    1897453 View commit details
    Browse the repository at this point in the history

  3. Update use_processor_flag doc 

    Signed-off-by: Abena Laast <[email protected]>
    @salaast
    salaast committed Jul 18, 2022
    Configuration menu
    Copy the full SHA
    39fc733 View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. close stdout and stderr, and write to devnull in supports_command, 

    remove open_url flag,
add processor_path env var and remove arg for use_processor_shell_path flag,
create Enable module for processor_path param

Signed-off-by: Abena Laast <[email protected]>
    @salaast
    salaast committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    4a91831 View commit details
    Browse the repository at this point in the history

  2. add clarifying comment 

    Signed-off-by: Abena Laast <[email protected]>
    @salaast
    salaast committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    679ad5d View commit details
    Browse the repository at this point in the history

  3. remove unnecessary async_shell from libraries 

    Signed-off-by: Abena Laast <[email protected]>
    @salaast
    salaast committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    681bf54 View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2022

  1. Change MAGIC_TRACE_PROCESSOR_SHELL to MAGIC_TRACE_TRACE_PROCESSOR_SHELL, 

    change processor_path to trace_processor_shell_path,
add comment about closing stdout and stderr breaking things,
better name for Enable module,
inline Enabled,
better name for value,
CR-someday for generalizing call_trace_processor with the perf version,
update processor flag doc to clarify conditional existence

Signed-off-by: Abena Laast <[email protected]>
    @salaast
    salaast committed Aug 5, 2022
    Configuration menu
    Copy the full SHA
    f567768 View commit details
    Browse the repository at this point in the history