Fixed Unsafe warnings and some improvements. #222
Conversation
AlaguSelvan
commented
Feb 12, 2020
AlaguSelvan
commented
- node.js config updated in Travis CI/CD.
- Added node.js 12 & Removed node.js 4 support in Travis CI/CD.
- Replaced ComponentWillMount to ComponentDidMount.
- Removed Trailing Commas and Unused Imports.
|
@jamiebuilds @tajo this is a highly needed feature, can we get this merged? |
| @@ -158,7 +158,7 @@ function createLoadableComponent(loadFn, options) { | |||
| return init(); | |||
| } | |||
|
|
|||
| componentWillMount() { | |||
| componentDidMount() { | |||
There was a problem hiding this comment.
This could introduce bugs, why don't you go the safe route and use UNSAFE_componentWillMount for now?
If you really want to go directly to didMount, this._mounted = true would need to move it to the constructor.
Calling retry from the loading component before the mount phase could cause unexpected behaviors with this change, for example.
The _loadModule is probably fine to stay here.
Unfortunately sounds like nobody will ever merge this anyway...
|
is the repo owner awol? I don't understand how a perfectly good pull request isn't acted upon. sheesh. guess that's the nature of npm and all these insane changesets from insane vendors. One must clone their own, hardcode their changes, and hardlock their application to a specific version for a specific purpose, and just give up on the future. |
|
If there is no response from owner then we can manage an active fork where we can merge all these PR's. Any volunteers? |
|
Will this be merged any time soon? Or this repo is unmaintaned at this point with no chances of getting any active PR's merged? |
|
Now that react comes loaded with lazy, this library doesn't hold much value. You can implement the same functionality with React lazy. |
