Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Babel 7 #151

Merged
merged 4 commits into from
Feb 28, 2020
Merged

Upgrade Babel 7 #151

merged 4 commits into from
Feb 28, 2020

Conversation

isacjunior
Copy link
Contributor

@isacjunior isacjunior commented Aug 31, 2018

Babel 7 Released

https://babeljs.io/blog/2018/08/27/7.0.0

Drop support for un-maintained Node versions: 0.10, 0.12, 4, 5 (details)

@t18n

This comment has been minimized.

@stephenway
Copy link

stephenway commented Sep 20, 2018

WARNING in ./src/chalkApp/screens/AppRoutes.js 59:30-38
export 'Loadable' was not found in 'react-loadable'
 @ ./src/chalkApp/index.js
 @ multi (webpack)-dev-server/client?http://localhost:3000 ./src/chalkApp/index.js

I'm running into this roadblock using Babel 7 and would like to get support.

@mohsinulhaq

This comment has been minimized.

@isacjunior

This comment has been minimized.

@ThamosIO

This comment has been minimized.

@jaybe78

This comment has been minimized.

@mohsinulhaq

This comment has been minimized.

@jaybe78

This comment has been minimized.

@jaybe78

This comment has been minimized.

@mohsinulhaq

This comment has been minimized.

@jaybe78
Copy link

jaybe78 commented Oct 22, 2018

I've forked and merged following PRs on my repo if anyone is interested:
[#151 Upgrade Babel 7
[#136 Switched to using two layers of .default to workaround a webpack/node bug
[#127 Migrate from legacy to new React lifecycle
[https://github.com//pull/110/files Migrate to webpack 4
[#132 Use webpack asset system instead of manually writing file
[#159 throw error instead of update

https://github.com/jaybe78/react-loadable

@mohsinulhaq

This comment has been minimized.

@jaybe78

This comment has been minimized.

@jaybe78
Copy link

jaybe78 commented Oct 23, 2018

@mohsinulhaq @isacjunior @ThamosIO
You've probably forked the project already to migrate to babel 7 but if not
please check this out https://www.npmjs.com/package/jaybe-react-loadable
Cheers

@VincentCharpentier

This comment has been minimized.

@jaybe78

This comment has been minimized.

@fishstix81

This comment has been minimized.

@aleehedl

This comment has been minimized.

@VincentCharpentier

This comment has been minimized.

@isacjunior
Copy link
Contributor Author

@aleehedl You need to use code splitting in server side? If not, I recommend using lazy with React. https://reactjs.org/docs/code-splitting.html#reactlazy

Repository owner deleted a comment from mohsinulhaq Feb 28, 2020
Repository owner deleted a comment from VincentCharpentier Feb 28, 2020
@jamiebuilds jamiebuilds merged commit 4e34a7f into jamiebuilds:master Feb 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.