Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Custom Error Messages With alloc Feature #81

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zicklag
Copy link

@zicklag zicklag commented Oct 19, 2022

Fixes #80.

I'm not sure if this is something you are interested in or not, but it got hard enough for me to go without it that I implemented it real quick. Let me know what you think!

@netlify
Copy link

netlify bot commented Oct 19, 2022

Deploy Preview for cute-starship-2d9c9b canceled.

Name Link
🔨 Latest commit b7d417c
🔍 Latest deploy log https://app.netlify.com/sites/cute-starship-2d9c9b/deploys/636e880d4d72520009227a97

Copy link
Contributor

@iFreilicht iFreilicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the concept overall, implementation is nice and the default message is very helpful.

src/error.rs Outdated Show resolved Hide resolved
src/error.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@iFreilicht iFreilicht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now. @jamesmunns, what do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Custom Error Messages
2 participants