Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Rails-style multiple dbs #80

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

fynsta
Copy link
Contributor

@fynsta fynsta commented Apr 4, 2024

This commit adds support for multiple databases in Active Record-style (https://guides.rubyonrails.org/active_record_multiple_databases.html). I tried to maintain backwards-compatibility (keeping multiverse as the default if databases are given, but this should surely be changed in the future.

Let me know if this approach makes sense to you. I will write tests if this feature is desired. It works locally for me.

@fynsta fynsta marked this pull request as draft April 4, 2024 13:12
@fynsta fynsta marked this pull request as ready for review April 4, 2024 16:02
@jalkoby jalkoby merged commit ca4beb5 into jalkoby:master Apr 10, 2024
8 checks passed
@jalkoby
Copy link
Owner

jalkoby commented Apr 10, 2024

version 0.8.0 is released. thanks for the contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants