Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate gRPC-Plugin support #5388

Merged
merged 12 commits into from May 11, 2024

Conversation

h4shk4t
Copy link
Contributor

@h4shk4t h4shk4t commented Apr 25, 2024

Which problem is this PR solving?

Description of the changes

  • Remove sidecar plugin support based on hashicorp go-plugin library.

Checklist

@h4shk4t h4shk4t requested a review from a team as a code owner April 25, 2024 14:05
Signed-off-by: Ashutosh Srivastava <[email protected]>
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please delete code, not comment out
  • changes look like in the right direction, but they don't compile

Signed-off-by: Ashutosh Srivastava <[email protected]>
Signed-off-by: Ashutosh Srivastava <[email protected]>
Copy link

codecov bot commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.51%. Comparing base (299d942) to head (84f06bd).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5388      +/-   ##
==========================================
+ Coverage   95.30%   95.51%   +0.21%     
==========================================
  Files         334      331       -3     
  Lines       16231    16107     -124     
==========================================
- Hits        15469    15385      -84     
+ Misses        582      550      -32     
+ Partials      180      172       -8     
Flag Coverage Δ
badger_v1 8.08% <0.00%> (+0.10%) ⬆️
badger_v2 1.94% <0.00%> (?)
cassandra-3.x-v1 16.49% <0.00%> (+0.21%) ⬆️
cassandra-3.x-v2 1.86% <0.00%> (+0.02%) ⬆️
cassandra-4.x-v1 16.49% <0.00%> (+0.21%) ⬆️
cassandra-4.x-v2 1.86% <0.00%> (+0.02%) ⬆️
elasticsearch-5.x 1.77% <0.00%> (+0.02%) ⬆️
elasticsearch-6.x 1.78% <0.00%> (+0.03%) ⬆️
elasticsearch-7.x 1.78% <0.00%> (+0.02%) ⬆️
elasticsearch-8.x 1.77% <0.00%> (+0.02%) ⬆️
grpc_v1 9.12% <100.00%> (-0.99%) ⬇️
grpc_v2 7.49% <0.00%> (+0.10%) ⬆️
kafka 9.82% <0.00%> (+0.12%) ⬆️
opensearch-1.x 1.77% <0.00%> (+0.01%) ⬆️
opensearch-2.x 1.78% <0.00%> (+0.02%) ⬆️
unittests 94.03% <12.50%> (+0.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Ashutosh Srivastava <[email protected]>
@h4shk4t h4shk4t changed the title [WIP] Deprecate gRPC-Plugin support Deprecate gRPC-Plugin support Apr 28, 2024
plugin/storage/grpc/config/config.go Outdated Show resolved Hide resolved
plugin/storage/grpc/options.go Outdated Show resolved Hide resolved
plugin/storage/grpc/shared/interface.go Show resolved Hide resolved
@yurishkuro yurishkuro added the changelog:breaking-change Change that is breaking public APIs or established behavior label May 11, 2024
yurishkuro and others added 6 commits May 11, 2024 14:55
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
@yurishkuro yurishkuro merged commit e9c819d into jaegertracing:main May 11, 2024
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog:breaking-change Change that is breaking public APIs or established behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants