New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate gRPC-Plugin support #5388
Merged
yurishkuro
merged 12 commits into
jaegertracing:main
from
h4shk4t:deprecate-grpc-plugin
May 11, 2024
Merged
Deprecate gRPC-Plugin support #5388
yurishkuro
merged 12 commits into
jaegertracing:main
from
h4shk4t:deprecate-grpc-plugin
May 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashutosh Srivastava <[email protected]>
yurishkuro
reviewed
Apr 25, 2024
Signed-off-by: Ashutosh Srivastava <[email protected]>
yurishkuro
reviewed
Apr 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- please delete code, not comment out
- changes look like in the right direction, but they don't compile
Signed-off-by: Ashutosh Srivastava <[email protected]>
Signed-off-by: Ashutosh Srivastava <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5388 +/- ##
==========================================
+ Coverage 95.30% 95.51% +0.21%
==========================================
Files 334 331 -3
Lines 16231 16107 -124
==========================================
- Hits 15469 15385 -84
+ Misses 582 550 -32
+ Partials 180 172 -8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Ashutosh Srivastava <[email protected]>
h4shk4t
changed the title
[WIP] Deprecate gRPC-Plugin support
Deprecate gRPC-Plugin support
Apr 28, 2024
yurishkuro
reviewed
Apr 30, 2024
yurishkuro
added
the
changelog:breaking-change
Change that is breaking public APIs or established behavior
label
May 11, 2024
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
yurishkuro
approved these changes
May 11, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Description of the changes
Checklist
jaeger
:make lint test
jaeger-ui
:yarn lint
andyarn test