Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use errors.New to replace fmt.Errorf with no parameters will much better #5377

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: use errors.New to replace fmt.Errorf with no parameters will much better #5377

wants to merge 1 commit into from

Conversation

ChengenH
Copy link

use errors.New to replace fmt.Errorf with no parameters will much better

@ChengenH ChengenH requested a review from a team as a code owner April 21, 2024 02:02
@ChengenH ChengenH changed the title chore: use errors.New to replace fmt.Errorf with no parameters will m… chore: use errors.New to replace fmt.Errorf with no parameters will much better Apr 21, 2024
mmorel-35
mmorel-35 approved these changes Apr 21, 2024
View reviewed changes
Copy link
Contributor

@mmorel-35 mmorel-35 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t there any linter like errorlint or gosimple that could ensure such best practice ?

@ChengenH
Copy link
Author

Isn’t there any linter like errorlint that could ensure such best practice ?

It's not serious, so...

@mmorel-35
Copy link
Contributor

"Heaven is in the details" would say Uncle Bob 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmorel-35 mmorel-35 mmorel-35 approved these changes

@albertteoh albertteoh Awaiting requested review from albertteoh albertteoh is a code owner automatically assigned from jaegertracing/jaeger-maintainers

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ChengenH @mmorel-35