Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add-keys_test.go #5249

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

take0420
Copy link

@take0420 take0420 commented Mar 5, 2024

Which problem is this PR solving?

Resolves :#5129

Description of the changes

  • Added 4 new unit tests in internal/metricstest/keys_test.go covering various scenarios for the GetKey function. These include:
  1. A basic case with a single tag.
  2. Multiple tags with sorting.
  3. A case with no tags.
  4. Multiple tags and special characters.

How was this change tested?

  • Testing:
    The new tests have been executed locally, and all passed successfully. Here's the output for reference:
=== RUN   TestGetKey
--- PASS: TestGetKey (0.00s)
PASS
ok      command-line-arguments  0.281s

Checklist

Thank you for considering my pull request.

Best regards,

@take0420

@take0420
Copy link
Author

take0420 commented Mar 5, 2024

This is my first time commitment 🙏🔰

https://goodfirstissue.dev/language/go

@Pushkarm029
Copy link
Member

Pushkarm029 commented Mar 5, 2024

@take0420, DCO is failing because your 1st commit wasn't signed.please follow the instructions present here: https://github.com/jaegertracing/jaeger/pull/5249/checks?check_run_id=22299996926

@yurishkuro
Copy link
Member

this looks just like a copy of #5249.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants