Skip to content
This repository has been archived by the owner on May 18, 2020. It is now read-only.

updated Prometheus endpoint #133

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rajputvishwas
Copy link

@rajputvishwas rajputvishwas commented Apr 6, 2020

based on Fix Prometheus endpoint #17264, 16686 is now replaced with 14269.

Which problem is this PR solving?

  • All-in-one.yaml file was using old Prometheus end point (16686), due to which Prometheus was not scrapping Jaeger metrics properly. This will resolve the problem of INVALID token error in Prometheus.

Short description of the changes

  • I have changed Prometheus end point 16686 to 14269

Copy link
Contributor

@objectiser objectiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.

Could you also make the same changes to the jaeger-production-template.yml:

  • agent metrics port should be 14271
  • collector metrics port should be 14269
  • query metrics port ahould be 16687

@@ -52,7 +52,7 @@ items:
protocol: UDP
- containerPort: 5778
protocol: TCP
- containerPort: 16686
- containerPort: 14269
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You shouldn't replace the existing port here - instead add another entry for the admin port.

based on Fix Prometheus endpoint #17264, 16686 is now replaced with 14269.

Signed-off-by: Rajput Vishwas <[email protected]>
 query-http port will remains 16686

Signed-off-by: Rajput Vishwas <[email protected]>
also need to update all-in-one port

Signed-off-by: Rajput Vishwas <[email protected]>
updated as per suggestion

Signed-off-by: Rajput Vishwas <[email protected]>
@pavolloffay
Copy link
Member

We are going to deprecate the repository. Please have a look at https://github.com/jaegertracing/jaeger-operator/#experimental-generate-kubernetes-manifest-file and share your feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants