scorecam update: nan fix for batch size less than 4 #173
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NAN issue with batch_size <=4 for scorecam.
Steps to reproduce the issue are as follows:
In cam.py,
#model = models.resnet50(pretrained=True)
model = models.vgg16(pretrained=True)
The output is as shown here:
https://github.com/sgsangodkar/pytorch-grad-cam/blob/scorecam_update/bsize4_before_scorecam_cam.jpg
Observation:
Output is not proper since there are 'nan's in the cam weights due to min max normalisation in scorecam.py file.
Possible Fix is as follows:
#maxs, mins = maxs[:, :, None, None], mins[:, :, None, None]
#upsampled = (upsampled - mins) / (maxs - mins)
Output after the fix is as shown here:
https://github.com/sgsangodkar/pytorch-grad-cam/blob/scorecam_update/bsize4_after_scorecam_cam.jpg
Regards
Sagar