-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add devcontainer setup #237
Conversation
leifwalsh
commented
Feb 28, 2022
- Install dev dependencies automatically
- Some useful extensions
- Add tasks.json to run tox/tests and build docs
e9e2bb3
to
4c69d27
Compare
* Install dev dependencies automatically * Some useful extensions * Add tasks.json to run tox/tests and build docs
4c69d27
to
4e6e0c8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome, thanks @leifwalsh! Left some minor questions/comments below. I pushed some followup changes (see 03d4a22) to my own jab/devcontainer
branch, since I didn't have permission to push directly to your fork. Let me know what you think, and thanks again for contributing this. Looking forward to merging it!
Codecov Report
@@ Coverage Diff @@
## main #237 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 14 14
Lines 622 622
Branches 99 99
=========================================
Hits 622 622 Continue to review full report at Codecov.
|
I do have "allow edits from maintainers" checked, so I'm not sure why you couldn't push to my branch, but I've pulled your changes into it, thank you. |
105e1b6
to
c14bfdc
Compare
e80769d
to
ebaf295
Compare
Pylance currently flags lots of type errors that mypy is not flagging and that look like false positives.