Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add devcontainer setup #237

Merged
merged 6 commits into from
Mar 3, 2022
Merged

Add devcontainer setup #237

merged 6 commits into from
Mar 3, 2022

Conversation

leifwalsh
Copy link
Contributor

  • Install dev dependencies automatically
  • Some useful extensions
  • Add tasks.json to run tox/tests and build docs

.devcontainer/Dockerfile Outdated Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
@leifwalsh leifwalsh marked this pull request as ready for review February 28, 2022 04:03
@gitpod-io
Copy link

gitpod-io bot commented Feb 28, 2022

* Install dev dependencies automatically
* Some useful extensions
* Add tasks.json to run tox/tests and build docs
build-docs.sh Outdated Show resolved Hide resolved
.devcontainer/Dockerfile Outdated Show resolved Hide resolved
Copy link
Owner

@jab jab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thanks @leifwalsh! Left some minor questions/comments below. I pushed some followup changes (see 03d4a22) to my own jab/devcontainer branch, since I didn't have permission to push directly to your fork. Let me know what you think, and thanks again for contributing this. Looking forward to merging it!

.devcontainer/devcontainer.json Show resolved Hide resolved
.devcontainer/devcontainer.json Outdated Show resolved Hide resolved
.vscode/tasks.json Outdated Show resolved Hide resolved
CONTRIBUTING.rst Show resolved Hide resolved
build-docs.sh Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 28, 2022

Codecov Report

Merging #237 (5d8f520) into main (db2b512) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #237   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           14        14           
  Lines          622       622           
  Branches        99        99           
=========================================
  Hits           622       622           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db2b512...5d8f520. Read the comment docs.

@leifwalsh
Copy link
Contributor Author

I do have "allow edits from maintainers" checked, so I'm not sure why you couldn't push to my branch, but I've pulled your changes into it, thank you.

@jab jab force-pushed the main branch 7 times, most recently from e80769d to ebaf295 Compare March 1, 2022 19:41
Pylance currently flags lots of type errors that mypy is not flagging
and that look like false positives.
@jab jab merged commit 7c736bf into jab:main Mar 3, 2022
@jab
Copy link
Owner

jab commented Mar 3, 2022

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants