feat: save and restore workspaces, add menu bar #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for webcrack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
0xdevalias
reviewed
May 18, 2024
|
|
||
| function restoreSavedModels() { | ||
| batch(() => { | ||
| models().forEach((model) => model.dispose()); |
There was a problem hiding this comment.
Does this clear any currently open tabs? If so, I wonder if that might be unexpected for users sometimes?
Realistically (at least with the current 5sec countdown on the restore dialog) it's probably rare (but not impossible) that you would get in a state of having open work that gets lost via this.
I wonder if making it so it only closes if it's the default/empty 'new tab' might be safer?
There was a problem hiding this comment.
Does this clear any currently open tabs
Yes, they can't be kept because each model needs to have an unique URI (path)
A possibility would be saving them before or showing a confirm dialog
j4k0xb
changed the title
This was referenced Jun 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #78