Add official support for Django 5.0 #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
browniebroke
force-pushed
the
django50-support
branch
from
1a7c2e5
to
0736c9f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 8 8
Lines 417 420 +3
=========================================
+ Hits 417 420 +3 ☔ View full report in Codecov by Sentry. |
browniebroke
force-pushed
the
django50-support
branch
from
c712e6d
to
fcee5a6
Compare
browniebroke
commented
Mar 26, 2024
Comment on lines
+5
to
+9
| - "3.8" | ||
| - "3.9" | ||
| - "3.10" | ||
| - "3.11" | ||
| - "3.12" |
There was a problem hiding this comment.
Not sure why all versions weren't present here, it seems like Travis wasn't supporting some of them back then? #139
| python \ | ||
| -W error::DeprecationWarning \ | ||
| -W error::PendingDeprecationWarning \ | ||
| -W "once:Converter 'drf_format_suffix' is already registered:" \ |
There was a problem hiding this comment.
That's a warning that shows up when running against Django main. I've switched the filter to log it once for now. I'm not too sure if the fix belongs here or in DRF to be honest.
|
Merged thanks ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.