Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits discarded by history rewriting should be ignored and branch considered as new #43

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

antoine-malliarakis
Copy link

@antoine-malliarakis antoine-malliarakis commented Nov 14, 2019

Checklist

  • All new jobs, commands, executors, parameters have descriptions (not relevant here)
  • Examples have been added for any significant new features (not relevant here)
  • README has been updated, if necessary (not relevant here)

Motivation, issues

Behaviours in case of branch being rebased or when the job previous runs included entries on commit which had been discarded (following a rebase or a squash) was... not working.

This is basically what's being described in the 3 below issues:

Description

Basically there was an issue which occurred with history rewrites (which can happen often in cases where people tend to squash their commits and / or rebase at head before merging, which is my case).

The idea is to basically say that:

  • If a commit from a previous build was lost it should be ignored
  • If a branch's previous job was on a no longer existing commit it should be considered as a new branch

@LoicEvenium
Copy link

This should fix #25 also I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants