Add shell-options parameter to use
#33
Open
+11
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscook2345
reviewed
Jul 8, 2019
| @@ -86,6 +86,7 @@ The `use` command also takes three optional parameters and one that is technical | |||
| | `attach-workspace` | `boolean` | `false` | Attach a workspace for this command to use? Useful when this orb's `reconstruct` job is called upstream in a given workflow | | |||
| | `workspace-root` | `string` | "." | Workspace root path (either an absolute path or a path relative to the working directory), defaults to "." (the working directory) | | |||
| | `custom-logic` | `string` | echo "What should COMMIT_RANGE ($COMMIT_RANGE) be used for?" | What should be done with the commit information created by the `reconstruct` command/job? [See examples in the orb registry](https://circleci.com/orbs/registry/orb/iynere/compare-url) (or [below](#examples)) | | |||
| | `shell-options` | `string` | /bin/bash -eo pipefail | The shell options for `custom-loginc`. Default is `/bin/bash -eo pipefail`. See the document for [using shell scripts](https://circleci.com/docs/2.0/using-shell-scripts/). | | |||
jscook2345
reviewed
Jul 8, 2019
| type: string | ||
| default: /bin/bash -eo pipefail | ||
| description: > | ||
| The shell options for `custom-loginc`. Default is `/bin/bash -eo pipefail`. |
|
@xdays these changes are part of the |
|
Ultimately I think it should be up to the maintainer(s). Some of the other issues in the repo may lead to larger refractors that may make both of our patches moot anyway :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, I added
shell-optionsparameter. please review 🙏Checklist
Motivation, issues
Useful to be able to select shell options when running custom-logic.
Description
I added
shell-optionsparameter touse. Default is/bin/bash -eo pipefail.