Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chat ls): support channel that has more than 101 topics #556

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

XMLHexagram
Copy link
Contributor

@XMLHexagram XMLHexagram commented Mar 25, 2024

fix #546

@pgotsis
Copy link

pgotsis commented Mar 27, 2024

I compiled it for linux/amd64 and it seems working.

@pgotsis
Copy link

pgotsis commented Apr 20, 2024

@XMLHexagram , I have used it a bit more. I retract my previous statement. It seems that it iterates "count" times over the topics, but after the 200th topic, it just iterates over the original results, with duplicates in the output.

I want to chase it myself as well. Where is the ChannelsGetForumTopicsRequest defined?

@iyear iyear self-assigned this Apr 30, 2024
@iyear iyear self-requested a review April 30, 2024 02:44
@iyear
Copy link
Owner

iyear commented Apr 30, 2024

@pgotsis @XMLHexagram Do you have any forums available for testing?

@pgotsis
Copy link

pgotsis commented Apr 30, 2024

I do. I will check in the next 1-2 days.

@XMLHexagram
Copy link
Contributor Author

XMLHexagram commented Jun 15, 2024

I can reproduce this issue via tdl chat ls on chat id = 1943412408 which is provide by origin issue, I am working on this issue.

@XMLHexagram
Copy link
Contributor Author

@iyear I test this PR on forum 1943412408 which is provided by origin issue and some other forums. It perfectly works.

I believe this PR can be merge into the main branch.

@XMLHexagram
Copy link
Contributor Author

XMLHexagram commented Jun 16, 2024

@iyear u can test it by subscribe https://t.me/haijiaovideo/1 and then use chat ls -f "len(Topics)>100" -o json.

This channel is provided by #546

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Issue with chat ls for chat with more then 101 topics
4 participants