Update trigonometric_functions.py

[athar-usama]

No description provided.

[athar-usama]

I also noticed an error in the file. Since, it was already merged, I did not think it appropriate to edit that line without telling someone from the Ivy team first.

[bicycleman15]

Hey @athar-usama could you please elaborate on what is the error ? if not, please link the issue in the comments that you are working on 🙂

[athar-usama]

Hi @bicycleman15

The error I am talking about is not in my function but in another function in this file. I noticed that under the "arccos" function definition, the unsupported dtype object is typed for "arcsin".

With that cleared, what is the update on my pull request? It has been 4 days since I created the pull request and there are still no reviews on it. How much longer will I have to wait?

P.S. I linked the issue in comments before creating the pull request. Even the comment has not been deleted yet. Why is this taking so long?

Issue: Add Mathematical functions to Numpy Frontend #1525
Labels: "ToDo", "NumPy Frontend", "Extension"
Comment: "arctanh" #3084

[github-actions]

This PR is stale because it has been open 7 days with no activity. Remove stale label or comment or this will be closed in 7 days.

[athar-usama]

@bicycleman15
Where are you? Why is no one reviewing? It has been 2 weeks.

[bicycleman15]

Hey @athar-usama, really sorry for the delay. Regarding the PR, I see that you have only implemented the frontend function, but not the test for it. Could you please implement that as well ? Refer to the contributor guide and deep dive for more info on how to add frontend tests. 🙂
Again, sorry for the delay.

[bicycleman15]

Regarding the error that you noticed, could you raise an issue for it and we can continue the discussion for it there separately.

[athar-usama]

Sure. I will check the contributor guide as well as the deep dive for adding frontend tests.
Also, will raise the issue for the other error separately.
Thank you.

[athar-usama]

Hi @bicycleman15
Just like you asked, I have now added the frontend test for my function as well. Kindly review.
Thank you.

[athar-usama]

@bicycleman15

It has been 7 days once again. Kindly let me know how much longer do I have to wait?

[bicycleman15]

LGTM ! Please resolve merge conflicts. I have approved the PR, so you can merge it yourself after resolving conflicts 🙂

Sorry for the delay.

[athar-usama]

That's great. Let me resolve the conflicts, and then I'll merge the PR.

Thanks a lot.

[athar-usama]

Close #3084

[athar-usama]

@bicycleman15

I have resolved the conflicts. Can you please guide me on how to merge the PR now? or you may merge it yourself please.

[athar-usama]

@bicycleman15

Can you please guide me on why is this pull request not being merged? There are no conflicts and it has been approved as well.

[bicycleman15]

Sorry for the delay, I have merged it manually now. Even I am not sure why you were not able to merge it yourself 🤔

[athar-usama]

@bicycleman15
Great. Thanks a lot.