Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arcsin - arccos [#1525] #2614

Merged
merged 9 commits into from
Aug 10, 2022
Merged

arcsin - arccos [#1525] #2614

merged 9 commits into from
Aug 10, 2022

Conversation

aman190202
Copy link
Contributor

Mathematical Functions, arcsin and arccos are added.

@aman190202
Copy link
Contributor Author

The failed checks are not from my commits but are pre-existing failed checks from other frontends which are outside the scope of my commit.

@kimbring2
Copy link
Contributor

kimbring2 commented Aug 6, 2022 •
edited by saeedashrraf
Loading

@aman190202 Hello, It seems like the arcsin and arccos were not tagged correctly in #1525.
Can you follow the step of this video? It starts at 01:26.

@saeedashrraf
Copy link
Contributor

Hello @aman190202, as @kimbring2 has mentioned, you should reserve the two functions with each being reserved through a separate issue.

@aman190202 aman190202 changed the title arcsin and arccos in #1525 addressed arcsin in #1525 addressed Aug 6, 2022
@aman190202
Copy link
Contributor Author

@aman190202 Hello, It seems like the arcsin and arccos were not tagged correctly in #1525.
Can you follow the step of this video? It starts at 01:26.

I have changed and now tagged this issue for arcsin. Thank you for the review.

@aman190202 aman190202 requested a review from saeedashrraf August 6, 2022 09:16
@aman190202 aman190202 changed the title arcsin in #1525 addressed arcsin [#1525] Aug 6, 2022
saeedashrraf
saeedashrraf suggested changes Aug 7, 2022
View reviewed changes
Copy link
Contributor

@saeedashrraf saeedashrraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to address the formatting issues detected by lint here? Thanks!

@aman190202
Copy link
Contributor Author

Can you try to address the formatting issues detected by lint here? Thanks!

Thanks for the review ; I have now resolved the lint issues

@aman190202 aman190202 requested a review from saeedashrraf August 7, 2022 19:03
@saeedashrraf saeedashrraf force-pushed the 1529 branch 2 times, most recently from 47a81e2 to fab137e Compare August 10, 2022 00:41
@saeedashrraf saeedashrraf merged commit 07c326a into ivy-llc:master Aug 10, 2022
@saeedashrraf saeedashrraf changed the title arcsin [#1525] arcsin - arccos [#1525] Aug 10, 2022
This was referenced Aug 10, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saeedashrraf saeedashrraf Awaiting requested review from saeedashrraf

Assignees

@saeedashrraf saeedashrraf

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aman190202 @kimbring2 @saeedashrraf