Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

floor #26016

Closed
wants to merge 10 commits into from
Closed

floor #26016

wants to merge 10 commits into from

Conversation

alikara345
Copy link

@alikara345 alikara345 commented Sep 24, 2023

PR Description

Related Issue

Close #22574

Checklist

  • Did you add a function?
  • Did you add the tests?
  • Did you run your tests and are your tests passing?
  • Did pre-commit not fail on any check?
  • Did you follow the steps we provided?

Socials:

sklearn linear regresyon
np floor
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Compliance Checks

Thank you for your Pull Request! We have run several checks on this pull request in order to make sure it's suitable for merging into this project. The results are listed in the following section.

Protected Branch

In order to be considered for merging, the pull request changes must not be implemented on the "main" branch. This is described in our Contributing Guide. We are closing this pull request and we would suggest that you implement your changes as described in our Contributing Guide and open a new pull request.

Conventional Commit PR Title

In order to be considered for merging, the pull request title must match the specification in conventional commits. You can edit the title in order for this check to pass.
Most often, our PR titles are something like one of these:

  • docs: correct typo in README
  • feat: implement dark mode"
  • fix: correct remove button behavior

Linting Errors

  • Found type "null", must be one of "feat","fix","docs","style","refactor","perf","test","build","ci","chore","revert"
  • No subject found

@soma2000-lang
Copy link
Contributor

@alikara345 kindly link the issue you are working on.

@alikara345
Copy link
Author

Add Mathematical functions to Numpy Frontend #1525
floor #22574

@soma2000-lang
Copy link
Contributor

soma2000-lang commented Oct 1, 2023

You need to implement the function and write test for it just as the others in the file has been done

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

Thank you for this PR, here is the CI results:


This pull request does not result in any additional test failures. Congratulations!

@alikara345
Copy link
Author

@soma2000-lang hi can you look results

@alikara345 alikara345 closed this Oct 6, 2023
@alikara345 alikara345 reopened this Oct 6, 2023
@soma2000-lang
Copy link
Contributor

You need to write the test foe the following added function.kindly cjeck how the other functions have been added.

@ivy-seed ivy-seed added the Stale label Nov 26, 2023
@ivy-seed
Copy link

This PR has been labelled as stale because it has been inactive for more than 7 days. If you would like to continue working on this PR, then please add another comment or this PR will be closed in 7 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

floor
6 participants